svn commit: r335856 - in head/sys: netinet sys

Steven Hartland steven.hartland at multiplay.co.uk
Tue Jul 10 07:52:17 UTC 2018


Sorry guys I didn't spot it was just a revert as it was tagged on to the 
end of the description, I would have expected that to be in the subject.

What do others think, is there an recommend style for revert commit 
messages?

     Regards
     Steve

On 02/07/2018 17:30, Rodney W. Grimes wrote:
> [ Charset UTF-8 unsupported, converting... ]
>> On Mon, Jul 2, 2018 at 10:44 AM Steven Hartland <
>> steven.hartland at multiplay.co.uk> wrote:
>>> You have M_WAITOK and a null check in this change
>> And, that's the same as the way it was before his commits. So, he did
>> exactly what he said he was doing and reverted his commits. I don't think
>> it is good practice to mix reverts with other changes.
> It is a very bad practive to mix a revert with anything.
>
>> Since you've noticed this, I think you should feel free to make the change.
>> Jonathan



More information about the svn-src-all mailing list