svn commit: r335856 - in head/sys: netinet sys

Rodney W. Grimes freebsd at pdx.rh.CN85.dnsmgr.net
Mon Jul 2 16:30:36 UTC 2018


[ Charset UTF-8 unsupported, converting... ]
> On Mon, Jul 2, 2018 at 10:44 AM Steven Hartland <
> steven.hartland at multiplay.co.uk> wrote:
> >
> > You have M_WAITOK and a null check in this change
> 
> And, that's the same as the way it was before his commits. So, he did
> exactly what he said he was doing and reverted his commits. I don't think
> it is good practice to mix reverts with other changes.

It is a very bad practive to mix a revert with anything.

> Since you've noticed this, I think you should feel free to make the change.
> Jonathan

-- 
Rod Grimes                                                 rgrimes at freebsd.org


More information about the svn-src-all mailing list