svn commit: r335856 - in head/sys: netinet sys

[Cy Schubert]

In message <CADrOrmse-LxVcV6oJZErprofTDBxBhPRKxnHm9OOoeGQ0yXHaQ at mail.gma
il.com>
, "Jonathan T. Looney" writes:
> On Mon, Jul 2, 2018 at 10:44 AM Steven Hartland <
> steven.hartland at multiplay.co.uk> wrote:
> >
> > You have M_WAITOK and a null check in this change
>
> And, that's the same as the way it was before his commits. So, he did
> exactly what he said he was doing and reverted his commits. I don't think
> it is good practice to mix reverts with other changes.

Yes, mixing reverts with other changes or batching changes together in 
one commit confuses history. This is my main criticism of Linux commit 
logs, IMO the worst example of commit log content. There they itemize a 
shopping list of changes or simply say, pull fixes for X from 
so-and-so, the patch passes our tests.

Five years from now or even a year from now, will anyone remember?

>
> Since you've noticed this, I think you should feel free to make the change.
>
> Jonathan


-- 
Cheers,
Cy Schubert <Cy.Schubert at cschubert.com>
FreeBSD UNIX:  <cy at FreeBSD.org>   Web:  http://www.FreeBSD.org

	The need of the many outweighs the greed of the few.