svn commit: r303626 - head/www/xpi-firebug

[Doug Barton]

On 9/4/2012 4:41 AM, Florian Smeets wrote:

> I still see this as a style nit. Can you be a bit more specific where
> portmaster fails with distinfo (or other files) not having the last
> newline?

I already explained it twice. :)

Take a file with no newline at the end. Do this:

while read line ; do
	echo $line
done < badfile

The last line will not be "seen" by the shell because of the missing
newline.

Portmaster, and other tools, use this method extensively to read those
files, and this issue causes those tools to break while processing those
files.

Doug

-- 

    I am only one, but I am one.  I cannot do everything, but I can do
    something.  And I will not let what I cannot do interfere with what
    I can do.
			-- Edward Everett Hale, (1822 - 1909)