svn commit: r303626 - head/www/xpi-firebug

[Florian Smeets]

On 04.09.12 18:35, Doug Barton wrote:
> On 9/4/2012 4:41 AM, Florian Smeets wrote:
> 
>> I still see this as a style nit. Can you be a bit more specific where
>> portmaster fails with distinfo (or other files) not having the last
>> newline?
> 
> I already explained it twice. :)
> 
> Take a file with no newline at the end. Do this:
> 
> while read line ; do
> 	echo $line
> done < badfile
> 
> The last line will not be "seen" by the shell because of the missing
> newline.

Yes, that is pretty clear.

> 
> Portmaster, and other tools, use this method extensively to read those
> files, and this issue causes those tools to break while processing those
> files.
> 

You keep repeating this, without proof. This is what I do not see, and
you so conveniently stripped that part out of your reply. portmaster
does not break for me when there is a missing newline at the end of
distinfo. It updates the port happily. This is what i meant with being
more specific, how can the failure be reproduced?

It seems most of this will be moot soon anyway, so maybe we should just
let this case rest.

However someone should perhaps fix all the files that have been added
without newline at the end of the file.

Florian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 163 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20120905/3cc9a2fe/attachment.sig>