svn commit: r303626 - head/www/xpi-firebug

Florian Smeets flo at smeets.im
Tue Sep 4 11:41:59 UTC 2012


On 09/04/2012 05:37, Doug Barton wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
> 
> On 09/03/2012 16:51, Florian Smeets wrote:
> 
>> So I reread the complete thread (r301039 and followups) again, the
>> only problem there seems to be is pchecker complaining,
> 
> It's a problem for anything that uses 'while read ...' to process
> those files, including portmaster.
> 
> If you have the list of files with this problem and aren't interested
> in fixing them, pass the list along and I'll do it.
> 

First of all, Doug thank you for fixing all of these. I should probably
have included the list of files, it was almost 2AM so I might have been
a bit sleepy already :)

I still see this as a style nit. Can you be a bit more specific where
portmaster fails with distinfo (or other files) not having the last
newline? It works just fine for me in that case. I'm really trying to
understand if something actually breaks.

I've also asked Shaun if he's aware of that problem and if he can give
hints on fixing this, so we won't have to keep fixing these or at least
eliminate one source of this problem.

Thanks,
Florian




More information about the svn-ports-all mailing list