make makepatch

Renato Botelho garga at FreeBSD.org
Thu Oct 27 10:17:23 UTC 2016


> On 27 Oct 2016, at 04:20, Kurt Jaeger <lists at opsec.eu> wrote:
> 
> Hi!
> 
>> # portlint
>> WARN: /usr/home/joneum/dev/ports/net/wpa_gui/files/patch-wpa_ctrl.c:
>> patch was not generated using ``make makepatch''.  It is recommended to
>> use ``make makepatch'' when you need to [re-]generate a patch to ensure
>> proper patch format.
>> 0 fatal errors and 1 warning found.
>> 
>> okay, i use "make makepatch", and copy the files from
>> "work/.makepatch-tmp/archived-patches" to the "/files" folder, and start
>> portlint. But, the same.
>> 
>> what am i doing wrong?
> 
> make makepatch places the corrected files into files/ and
> the prevision version to work/.makepatch-tmp/archived-patches.
> 
> So, I'd suggest:
> 
> make patch
> make makepatch
> mv work work.old
> portlint -AC
> 
> and if portlint is silent, and all the necessary patches are in files/,
> you're done.


I only suggest to replace ‘make patch’ by:

# make extract do-patch

There are several ports that changes files using REINPLACE_CMD in post-patch: target, this way you will not run post-patch: and will not risky to end up converting REINPLACE_CMD into static patches.
--
Renato Botelho



More information about the freebsd-ports mailing list