net/unison240 depends on lang/ocaml-nox11

[Guido Falsi]

On 03/21/15 17:55, Michael Grimm wrote:
> 
>> On 21.03.2015, at 15:50, Guido Falsi <madpilot at FreeBSD.org> wrote:
>> On 03/21/15 14:50, Michelle Sullivan wrote:
> 
> 
>>> Which means that if unsetting X11 on in the port and not globally ocaml
>>> is built with X11 and unison without - which poudriere will fail on when
>>> it tries to find the dependencies...  which means my thoughts were
>>> exactly the opposite ... poudriere scans the dependency tree on startup
>>> which picks up the -nox11 package as a dependency then builds with x11
>>> when it builds ocaml...
>>
>> Exactly.
>>
>> There are four cases:
>>
>> one asks for both with or without X11, works fine, in both.
>>
>> one asks for ocaml without X11 and unison with X11, this is wrong and
>> cannot obviously work.
>>
>> last case is asking for ocaml with X11 and unison without. This could
>> work in theory, and will work on a live system, but will not work in
>> poudriere at present, due to ocaml changing it's package name
>> dynamically. I don't know how to make it work with the present ports system.
>>
>> This fourth case anyway makes little sense to me anyway, once you have
>> pulled in the X11 dependency why not use it in all ports which can take
>> advantage of it?
> 
> 
> I recently (after last upgrade of poudriere-devel, although I do not know if that is the cause) ran into a comparable issue with unison without X11 :
> 
> 	| MWN> cat /usr/local/etc/poudriere.d/stable10-make.conf
> 	| WITHOUT_X11=yes
> 	[...]

I don't think old style WITH_/WITHOUT_ flags are supported anymore.
Looking at the code you should in fact get a warning about this.

You really should move to the new style OPTIONS_UNSET/OPTIONS_SET.

You can find some documentation in /usr/ports/Mk/bsd.options.mk



> 
> 	| MWN> pkg info | grep unison
> 	| unison-nox11-2.48.3_1          User-level file synchronization tool (without x11 stuff)
> 
> poudriere's build failed with:
> 
> 	| MWN> cat  /.../logs/ocaml-nox11-4.01.0_4.log
> 	| ---Begin OPTIONS List---
> 	| ===> The following configuration options are available for ocaml-nox11-4.01.0_4:
> 	|      DOCS=on: Build and/or install documentation
> 	|      EXAMPLES=on: Build and/or install examples
> 	|      THREADS=on: Threading support
> ---->	|      TK=on: LablTk library (requires X11 support)
> 	|      X11=off: X11 (graphics) support
> 	| ===> Use 'make config' to modify these settings
> 	| ---End OPTIONS List---
> 	[...]
> 	| ---End make.conf---
> 	| ====>> Ignoring lang/ocaml: requires X11 support to build TK bindings
> 	| build of lang/ocaml ended at Sat Mar 21 17:08:37 CET 2015
> 
> That's weird, ocaml-nox11 defaults to "TK=on" which requires X11 support. Bug or feature?

You sure you have no option directory with per port options enabling TK?
Options activate per port do override WITH_/WITHOUT_ and
OPTIONS_UNSET/OPTIONS_SET.

-- 
Guido Falsi <mad at madpilot.net>