net/unison240 depends on lang/ocaml-nox11

[Michael Grimm]

On 21.03.2015, at 19:10, Guido Falsi <mad at madpilot.net> wrote:
> On 03/21/15 17:55, Michael Grimm wrote:

>> I recently (after last upgrade of poudriere-devel, although I do not know if that is the cause) ran into a comparable issue with unison without X11 :
>> 
>> 	| MWN> cat /usr/local/etc/poudriere.d/stable10-make.conf
>> 	| WITHOUT_X11=yes
>> 	[...]
> 
> I don't think old style WITH_/WITHOUT_ flags are supported anymore.
> Looking at the code you should in fact get a warning about this.

Hmm, not that I am aware of. But I will have a closer look. But! Commenting that "WITHOUT_X11=yes" has been recognized by poudriere: the unison-nox11 port could be compiled successfully with default ocaml settings.

> You really should move to the new style OPTIONS_UNSET/OPTIONS_SET.
> You can find some documentation in /usr/ports/Mk/bsd.options.mk

Thanks for that pointer.

>> 	| MWN> pkg info | grep unison
>> 	| unison-nox11-2.48.3_1          User-level file synchronization tool (without x11 stuff)
>> 
>> poudriere's build failed with:
>> 
>> 	| MWN> cat  /.../logs/ocaml-nox11-4.01.0_4.log
>> 	| ---Begin OPTIONS List---
>> 	| ===> The following configuration options are available for ocaml-nox11-4.01.0_4:
>> 	|      DOCS=on: Build and/or install documentation
>> 	|      EXAMPLES=on: Build and/or install examples
>> 	|      THREADS=on: Threading support
>> ---->	|      TK=on: LablTk library (requires X11 support)
>> 	|      X11=off: X11 (graphics) support
>> 	| ===> Use 'make config' to modify these settings
>> 	| ---End OPTIONS List---
>> 	[...]
>> 	| ---End make.conf---
>> 	| ====>> Ignoring lang/ocaml: requires X11 support to build TK bindings
>> 	| build of lang/ocaml ended at Sat Mar 21 17:08:37 CET 2015
>> 
>> That's weird, ocaml-nox11 defaults to "TK=on" which requires X11 support. Bug or feature?
> 
> You sure you have no option directory with per port options enabling TK?

Yes, I'm sure that I haven't had an option directory with per port options en/disabling TK set.

> Options activate per port do override WITH_/WITHOUT_ and
> OPTIONS_UNSET/OPTIONS_SET.

Only, *after* setting "OPTIONS_FILE_UNSET+=TK" in lang_ocaml/options, I was able to get unison-nox11 port compiled by poudriere successfully. *Before* I haven't had any lang_ocaml/options settings at all. And because the default setting of ocaml-nox11 is "OPTIONS_FILE_SET+=TK" -which requires X11 support (!)- poudriere fails compiling ocaml-nox11 port. (If I am not mistaken miserably.)

Regards,
Michael