NOPORTDOCS and NOPORTEXAMPLES

[Baptiste Daroussin]

On Sun, Jun 10, 2012 at 06:05:49PM -0600, Warren Block wrote:
> On Sun, 10 Jun 2012, Jason Helfman wrote:
> 
> >> So references to NOPORTDOCS should be replaced with references to
> >> PORT_OPTIONS:MDOCS now?  Why that but not NOPORTEXAMPLES?
> >
> > You can use PORT_OPTIONS:MEXAMPLES for this case.
> >
> > I believe I did this recently in www/flot
> 
> But only after bsd.port.options.mk is included.  Here's what I was 
> trying to do:
> 
> .if ${PORT_OPTIONS:MDOCS}
> OPTIONS_DEFINE+=        REFDOCS
> REFDOCS_DESC=           Install the reference documents
> OPTIONS_DEFAULT+=       REFDOCS
> .endif
> 
> .if ${PORT_OPTIONS:MEXAMPLES}
> OPTIONS_DEFINE+=        EXAMPLES
> EXAMPLES_DESC=          Install the example code
> OPTIONS_DEFAULT+=       EXAMPLES
> .endif
> 
> .include <bsd.port.options.mk>
> 

Why not simply that way:

OPTIONS_DEFINE=	... DOCS EXAMPLES

DOCS_DESC=	Install the reference documents

And done.

Condtion an EXAMPLES on EXAMPLES options doesn't make sense to me.

by default DOCS and EXAMPLES are on expect if the user set NOPORTDOCS,
NOPORTEXAMPLES or OPTIONS_UNSET= DOCS EXAMPLES

regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20120611/0bbc1295/attachment.pgp