[Bug 195014] [NEW PORT] games/diaspora: Single and multiplayer space fighter combat game

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=195014

--- Comment #18 from John Marino <marino at FreeBSD.org> ---
(In reply to lightside from comment #17)
> If distinfo is changed, the
> maintainer will need to check plist issues again, regardless of the method
> used. The port also control the do-install stage.

If the distfile changes and the maintainer *doesn't* check the plist, it will
pass even if the empty directories change.  So nothing forces the maintainer to
actually check -- only if a new file gets install would a problem be detected
by qa checks.



> Well, if you want to check issues of this port, you will need to check
> attached logs, check-plist and portlint results, which means to use
> poudriere (or tinderbox), either just install/deinstall the port (and
> games/wxlauncher, which is needed from 195013 bug report). But beware, this
> might take many hours (depending from the test method used and hardware
> capabilities). I did it and I know what I talking about.


You're missing the point.
If there is a static manifest (pkg-plist), anybody can run QA checks on any
platform and be confident what is installed is what the maintainer intended. 
This is impossible for ports with autogen plists.


> 
> Personally, I used dynamic package list generation for many ports and they
> are still works.

dynamic plists are scrutinized now.  I would wager if this "many ports" are
still active today, many would face recommendations to convert them to a static
pkg-plist.  Of course, I'm just guessing without having seen these ports.

I acknowledge this is a very low-risk port in any case.  I'll promote the PR to
the next level with a static plist.  If you insist on a dynamic plist then I'll
let someone else promote it.

-- 
You are receiving this mail because:
You are the assignee for the bug.