[Bug 195014] [NEW PORT] games/diaspora: Single and multiplayer space fighter combat game

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=195014

lightside <lightside at gmx.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #149457|0                           |1
        is obsolete|                            |

--- Comment #19 from lightside <lightside at gmx.com> ---
Created attachment 149465
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=149465&action=edit
The port in shar format

(In reply to John Marino from comment #18)
> If the distfile changes and the maintainer *doesn't* check the plist, it
> will pass even if the empty directories change.  So nothing forces the
> maintainer to actually check -- only if a new file gets install would a
> problem be detected by qa checks.

Actually, I tested the port (poudriere testport) without using empty
directories package list generation at first and I got stage-qa issue about
stage directories not in a package list. These directories might be important
for users, if they wanted to add files to them (either by root privileges or
copy/link the share/diaspora directory to a different location). Therefore, I
added dynamic generation for empty directories to ${TMPPLIST}. After this, the
stage-qa was ok:
====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
===> No pkg-plist issues found (check-plist)
====>> Checking for staging violations... done

After discussion, I changed the generation of empty directory list to the
following command:
cd ${STAGEDIR}${DATADIR} && ${FIND} data -type d -empty | ${SORT} |\
    ${XARGS} -L 1 -I '{}' ${ECHO_CMD} "@dir ${DATADIR}/{}"\
    >> ${TMPPLIST}

The ${STAGEDIR}${DATADIR} is more appropriate place.

In the next message I will attach the ${WRKDIR} directory archive of the files
after "make check-plist" command. It contains .* hidden files, which you could
examine about correctness, especially .PLIST.mktmp,
.plist-dirs-sorted-no-comments, .plist-files-no-comments.

(In reply to John Marino from comment #18)
> I acknowledge this is a very low-risk port in any case.  I'll promote the PR
> to the next level with a static plist.  If you insist on a dynamic plist
> then I'll let someone else promote it.

I understood. I just think that my method is also correct. Moreover, I have
documented results of it written to logs, which is about 3 hours of computer
time (because of package generation) for three FreeBSD versions, not counting
undocumented computer time for correct result, even on one FreeBSD version.
The easy way to check this is just install the port, then find empty
"/usr/local/share/diaspora/data" directories, next deinstall the port and find
that there is no "/usr/local/share/diaspora" directory, e.g.:
# portmaster -Bd games/diaspora
# find /usr/local/share/diaspora/data -type d -empty | sort
# pkg delete -x diaspora
# ls /usr/local/share/diaspora

What I could offer is another poudriere testport log of current changes for
FreeBSD 10 amd64 version.

-- 
You are receiving this mail because:
You are the assignee for the bug.