[Bug 195014] [NEW PORT] games/diaspora: Single and multiplayer space fighter combat game

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=195014

--- Comment #16 from John Marino <marino at FreeBSD.org> ---
(In reply to lightside from comment #15)
> I meant, it adapts to differences of the package contents, which is based on
> contents of the distfiles, in case there are new or deleted files in
> specified directories. The files are installed in correct places, specified
> at package creation or manual build time.

I know what you meant.  
We could easily remove every pkg-plist in the entire tree and have it autogen'd
based on what is in the stage.  Then it would "adapt" to every new version
without breaking the port.  But we don't do that -- there's a reason.


> 
> About the pkg-plist discussion:
> I think, this is a maintainer/creator's choice. The static pkg-plist or
> PLIST_FILES are correct choices, because they lead to the same result:
> correctly installed port. 

That's a claim you can't back up.
By definition, every build will be "correctly installed".  Without a manifest,
there's nothing to check again, so nobody can verify if it's installed correct
or not.

Maintainer's don't really have the freedom to do something against policy. 
Personally, I'm not going to approve an autogen list for this port.  Maybe
somebody else will.


> The logs shows correct results for current method.
> I don't intend to change it because of "count of files" argument. Even if
> there was only one file, e.g. bin/fs2_open_diaspora inside of PLIST_FILES or
> pkg-plist file are correct choices.


count of files kicks in at like 5,000 files, not 30.


> Do you talk about the platforms, which are not working, may be? I tested it
> on amd64 only. If this port will not work for some platform, the commiter
> could specify these restrictions later. Moreover, I suggested to add
> MANUAL_PACKAGE_BUILD=yes to Makefile, because of the size of the
> distfiles/package and resources they use by extract/creation stage(s). I
> didn't include it, because of poudriere testport logs.

The point is a manifest is needed to detect issues, and issues are more likely
to happen on platforms you didn't check.  no manifest means every port passes
by default, even if it's missing files or has extra files which can easily
occur.


> By the way, I specified README*.txt files instead of just *.txt inside of
> ${WRKDIR} directory for copy to ${STAGEDIR}${DOCSDIR} directory in the new
> attached shar file.


If you aren't going to change this submission, it's up to you.  I'll just
remove myself off of CC and you can hope the next guy that reviews it thinks
it's okay.  I guess your chances of that are okay because it's only empty
directories you are autogenning and in the end that is not as critical as
files.

-- 
You are receiving this mail because:
You are the assignee for the bug.