[Bug 195014] [NEW PORT] games/diaspora: Single and multiplayer space fighter combat game

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=195014

lightside <lightside at gmx.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #149435|0                           |1
        is obsolete|                            |

--- Comment #15 from lightside <lightside at gmx.com> ---
Created attachment 149457
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=149457&action=edit
The port in shar format

(In reply to John Marino from comment #14)
> But this is exactly why autogen is frowned upon -- it adapts to the
> differences and that can cause surprises when changes are obscured,
> especially between platforms.  Since we are only talking about a pkg-plist
> of about 30 lines, I think this should be converted to the static pkg-plist
> file.

I meant, it adapts to differences of the package contents, which is based on
contents of the distfiles, in case there are new or deleted files in specified
directories. The files are installed in correct places, specified at package
creation or manual build time.

About the pkg-plist discussion:
I think, this is a maintainer/creator's choice. The static pkg-plist or
PLIST_FILES are correct choices, because they lead to the same result:
correctly installed port. The logs shows correct results for current method. I
don't intend to change it because of "count of files" argument. Even if there
was only one file, e.g. bin/fs2_open_diaspora inside of PLIST_FILES or
pkg-plist file are correct choices.

Do you talk about the platforms, which are not working, may be? I tested it on
amd64 only. If this port will not work for some platform, the commiter could
specify these restrictions later. Moreover, I suggested to add
MANUAL_PACKAGE_BUILD=yes to Makefile, because of the size of the
distfiles/package and resources they use by extract/creation stage(s). I didn't
include it, because of poudriere testport logs.

By the way, I specified README*.txt files instead of just *.txt inside of
${WRKDIR} directory for copy to ${STAGEDIR}${DOCSDIR} directory in the new
attached shar file.

-- 
You are receiving this mail because:
You are the assignee for the bug.