locale-related review, wcwidth() data

Yuri Pankov yuripv at yuripv.dev
Sat Dec 5 01:33:11 UTC 2020


Thomas Munro wrote:
> On Sat, Dec 5, 2020 at 2:31 AM Baptiste Daroussin <bapt at freebsd.org> wrote:
>> I do like what I see here, the only reason I haven't review is that I can't
>> test, since the last modification from hrs@ in the locale generation tools each
>> time I try to regenerate the locales it fails.
> 
> During install?  I noticed that too but wasn't sure of the correct fix, perhaps:
> 
> diff --git a/tools/tools/locale/Makefile b/tools/tools/locale/Makefile
> index 76fff6acb17..b6ae2feadac 100644
> --- a/tools/tools/locale/Makefile
> +++ b/tools/tools/locale/Makefile
> @@ -95,7 +95,7 @@ install: install-${t}
>   install-${t}:
>          cd ${LOCALESRCDIR}/${t} && \
>              rm -f Makefile *.src && \
> -           install -c ${t}/* ${LOCALESRCDIR}/${t}
> +           install -c ${.OBJDIR}/${t}/* ${LOCALESRCDIR}/${t}
>   .  endif
>   .endfor

Makes sense.

BTW, to test what is in this review, you don't need the install target 
-- new 'width' target depends only on cldr posix data itself, and 
modifies etc/final-maps/widths.txt directly.


More information about the freebsd-hackers mailing list