locale-related review, wcwidth() data

Hiroki Sato hrs at FreeBSD.org
Mon Dec 7 04:51:10 UTC 2020

Yuri Pankov <yuripv at yuripv.dev> wrote
  in <14fbfd11-a5fa-4e7e-422c-33738364c58d at yuripv.dev>:

yu> Thomas Munro wrote:
yu> > On Sat, Dec 5, 2020 at 2:31 AM Baptiste Daroussin <bapt at freebsd.org>
yu> > wrote:
yu> >> I do like what I see here, the only reason I haven't review is that I
yu> >> can't
yu> >> test, since the last modification from hrs@ in the locale generation
yu> >> tools each
yu> >> time I try to regenerate the locales it fails.
yu> > During install?  I noticed that too but wasn't sure of the correct
yu> > fix, perhaps:
yu> > diff --git a/tools/tools/locale/Makefile b/tools/tools/locale/Makefile
yu> > index 76fff6acb17..b6ae2feadac 100644
yu> > --- a/tools/tools/locale/Makefile
yu> > +++ b/tools/tools/locale/Makefile
yu> > @@ -95,7 +95,7 @@ install: install-${t}
yu> >   install-${t}:
yu> >          cd ${LOCALESRCDIR}/${t} && \
yu> >              rm -f Makefile *.src && \
yu> > -           install -c ${t}/* ${LOCALESRCDIR}/${t}
yu> > +           install -c ${.OBJDIR}/${t}/* ${LOCALESRCDIR}/${t}
yu> >   .  endif
yu> >   .endfor
yu> Makes sense.
yu> BTW, to test what is in this review, you don't need the install target
yu> -- new 'width' target depends only on cldr posix data itself, and
yu> modifies etc/final-maps/widths.txt directly.

 Sorry for keeping silence about the report.  I fixed it in r368404.

-- Hiroki
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 342 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-hackers/attachments/20201207/77d9d9fc/attachment.sig>

More information about the freebsd-hackers mailing list