gf128_add can be marked as __pure2

Eitan Adler lists at eitanadler.com
Sat Mar 17 18:39:01 UTC 2018


On 17 March 2018 at 10:38, John-Mark Gurney <jmg at funkthat.com> wrote:
> Eitan Adler wrote this message on Mon, Feb 19, 2018 at 19:15 -0800:
>> Is there any reason not to apply this patch?
>
> I don't see why there wouldn't be..
>
>> __pure2 means  __attribute__((const)) which is correct in this case as
>>  gf128_add read no global memory:
>
> Are these documented some where?  Looksl ike __pure2 was created instead
> of using __pure for some reason...  I wish these things were documented
> properly so others could know the correct usage...

I don't know where the FreeBSD macros are documented (they are
implementedi cdefs.h).
https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#Common-Function-Attributes
documents the attributes

__pure2 is const
__pure is pure

-- 
Eitan Adler


More information about the freebsd-hackers mailing list