gf128_add can be marked as __pure2
jmg at funkthat.com
Sat Mar 17 17:46:23 UTC 2018
Eitan Adler wrote this message on Mon, Feb 19, 2018 at 19:15 -0800:
> Is there any reason not to apply this patch?
I don't see why there wouldn't be..
> __pure2 means __attribute__((const)) which is correct in this case as
> gf128_add read no global memory:
Are these documented some where? Looksl ike __pure2 was created instead
of using __pure for some reason... I wish these things were documented
properly so others could know the correct usage...
> Index: gfmult.h
> --- gfmult.h (revision 329611)
> +++ gfmult.h (working copy)
> @@ -108,7 +108,7 @@ gf128_write(struct gf128 v, uint8_t *buf)
> be64enc(buf, v.v);
> -static inline struct gf128 __pure /* XXX - __pure2 instead */
> +static inline struct gf128 __pure2
> gf128_add(struct gf128 a, struct gf128 b)
> a.v ^= b.v;
John-Mark Gurney Voice: +1 415 225 5579
"All that I will do, has been done, All that I have, has not."
More information about the freebsd-hackers