kern/149762: volume labels with rogue characters

[Oliver Fromme]

The following reply was made to PR kern/149762; it has been noted by GNATS.

From: Oliver Fromme <olli at lurza.secnetix.de>
To: freebsd-geom at FreeBSD.ORG, bug-followup at FreeBSD.ORG, walter at pelissero.de
Cc:  
Subject: Re: kern/149762: volume labels with rogue characters
Date: Wed, 18 Aug 2010 19:06:26 +0200 (CEST)

 Oliver Fromme wrote:
  >  I have reviewed the patch (the second one from the followup),
  >  and it looks good to me, except for a few minor style(9)
  >  issues, and one type problem:  By default, char is unsigned,
                                               ^^^^^^^^^^^^^^^^^^
  >  so the comparisons p <= ' ' and p > '~' probably don't do
  >  what you expect.
 
 I'm sorry, I meant signed, of course.
 You need to specify "unsigned char" if you want it to be unsigned.
 
 Best regards
    Oliver
 
 -- 
 Oliver Fromme, secnetix GmbH & Co. KG, Marktplatz 29, 85567 Grafing b. M.
 Handelsregister: Registergericht Muenchen, HRA 74606,  Geschäftsfuehrung:
 secnetix Verwaltungsgesellsch. mbH, Handelsregister: Registergericht Mün-
 chen, HRB 125758,  Geschäftsführer: Maik Bachmann, Olaf Erb, Ralf Gebhart
 
 FreeBSD-Dienstleistungen, -Produkte und mehr:  http://www.secnetix.de/bsd
 
 "C is quirky, flawed, and an enormous success."
         -- Dennis M. Ritchie.