kern/149762: volume labels with rogue characters

[Kostik Belousov]

On Wed, Aug 18, 2010 at 07:06:26PM +0200, Oliver Fromme wrote:
> Oliver Fromme wrote:
>  >  I have reviewed the patch (the second one from the followup),
>  >  and it looks good to me, except for a few minor style(9)
>  >  issues, and one type problem:  By default, char is unsigned,
>                                               ^^^^^^^^^^^^^^^^^^
>  >  so the comparisons p <= ' ' and p > '~' probably don't do
>  >  what you expect.
> 
> I'm sorry, I meant signed, of course.
> You need to specify "unsigned char" if you want it to be unsigned.

Signedness of char is implementation-depended. It is signed on x86-oids,
and unsigned on powerpc, AFAIR.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-geom/attachments/20100818/7357fb16/attachment.pgp