kern/149762: volume labels with rogue characters

[Kostik Belousov]

The following reply was made to PR kern/149762; it has been noted by GNATS.

From: Kostik Belousov <kostikbel at gmail.com>
To: Oliver Fromme <olli at lurza.secnetix.de>
Cc: freebsd-geom at freebsd.org, bug-followup at freebsd.org, walter at pelissero.de
Subject: Re: kern/149762: volume labels with rogue characters
Date: Wed, 18 Aug 2010 21:58:31 +0300

 --b6tME5Uow9dgAUD7
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 On Wed, Aug 18, 2010 at 07:06:26PM +0200, Oliver Fromme wrote:
 > Oliver Fromme wrote:
 >  >  I have reviewed the patch (the second one from the followup),
 >  >  and it looks good to me, except for a few minor style(9)
 >  >  issues, and one type problem:  By default, char is unsigned,
 >                                               ^^^^^^^^^^^^^^^^^^
 >  >  so the comparisons p <=3D ' ' and p > '~' probably don't do
 >  >  what you expect.
 >=20
 > I'm sorry, I meant signed, of course.
 > You need to specify "unsigned char" if you want it to be unsigned.
 
 Signedness of char is implementation-depended. It is signed on x86-oids,
 and unsigned on powerpc, AFAIR.
 
 --b6tME5Uow9dgAUD7
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.10 (FreeBSD)
 
 iEYEARECAAYFAkxsLVcACgkQC3+MBN1Mb4jcDQCfUYofBvJScewmXBYPLljLETSO
 798An0wmSPW4dbr4fReYCvPaN/9AbLdl
 =sCVM
 -----END PGP SIGNATURE-----
 
 --b6tME5Uow9dgAUD7--