[Differential] [Commented On] D2377: Introduce ARM GICv3 support

Wed Apr 29 17:53:51 UTC 2015

zbb added inline comments.

INLINE COMMENTS
  sys/arm64/arm64/gic_v3.c:160 From style(9):
  No	braces (`{' and `}') are used for control statements with zero	or only a single statement unless that statement is	more than a single line in which case they are permitted.
  sys/arm64/arm64/gic_v3.c:255 This is the same "32" as in "uint32_t".
  I can see a certain amount of exaggeration to define things. I don't think using 
  ```
  sizeof(uint32_t) * NBBY
  ```
  looks better here.
  sys/arm64/arm64/gic_v3.c:265 This may be more reasonable
  sys/arm64/arm64/gic_v3.c:351 yes, yes READ_SPECIALREG
  sys/arm64/arm64/gic_v3.c:438 This can be changed to FIRST_SPI indeed.
  sys/arm64/arm64/gic_v3_reg.h:108 Scroll down to locore.S please

REPOSITORY
  rS FreeBSD src repository

REVISION DETAIL
  https://reviews.freebsd.org/D2377

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: zbb, emaste, ian, imp, andrew, brueffer, joel, wblock
Cc: kostikbel, emaste, andrew, imp, freebsd-arm