[Differential] [Commented On] D2377: Introduce ARM GICv3 support

Mon Apr 27 14:24:50 UTC 2015

andrew added inline comments.

INLINE COMMENTS
  sys/arm64/arm64/gic_v3.c:91 What is this needed for if it's marked as unused?
  sys/arm64/arm64/gic_v3.c:160 Extra braces
  sys/arm64/arm64/gic_v3.c:255 Why 32?
  sys/arm64/arm64/gic_v3.c:265 Should this be a panic?
  sys/arm64/arm64/gic_v3.c:351 Isn't there a macro for this?
  sys/arm64/arm64/gic_v3.c:356 READ_SPECIALREG
  sys/arm64/arm64/gic_v3.c:422 Magic numbers and extra braces
  sys/arm64/arm64/gic_v3.c:438 What is special about 32?
  sys/arm64/arm64/gic_v3.c:566 Magic numbers
  sys/arm64/arm64/gic_v3_fdt.c:96 We should use a common gicv3 base class, then this subclass will only be the fdt specific bits.
  sys/arm64/arm64/gic_v3_reg.h:108 What register is this for?
  sys/arm64/arm64/gic_v3_reg.h:142 This should use WRITE_SPECIALREG
  sys/arm64/arm64/gic_v3_reg.h:150 READ_SPECIALREG

REPOSITORY
  rS FreeBSD src repository

REVISION DETAIL
  https://reviews.freebsd.org/D2377

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: zbb, emaste, ian, imp, andrew, brueffer, joel, wblock
Cc: kostikbel, emaste, andrew, imp, freebsd-arm