Re: [PATCH] OvmfPkg/BhyveBhf: install bhyve's ACPI tables

On Mon, 2023-04-03 at 21:26 +1000, Peter Grehan wrote:
> Hi Corvin,
> 
> > I would like to send the following patch to the EDKII project.
> > Therefore, I'd like to get some feedback from the bhyve community
> > before
> > sending them to EDKII.
> 
>   Thanks for giving a heads-up.
> 
>   The patch looks fine to me. The only minor suggestion I have is to
> use 
> the qemu fwcfg interface to locate the RSDP instead of searching
> through 
> memory, since presumably any new ACPI table functionality in bhyve
> would 
> be after this point in time where qemu fwcfg is already supported.
> 
> later,
> 
> Peter.

Hi Peter,

thanks for your reply.

Using the qemu fwcfg has one big disadvantage:
Bhyve's fwctl and qemu's fwcfg can't be used at the same time. Due to
backward compatibility reasons, bhyve uses fwctl as default. So, using
qemu's fwcfg to locate the rsdp only works, if the user changes his
bhyve call.
I don't want to use fwctl to locate the rsdp because IMHO we should
migrate to fwcfg. So, we shouldn't add new features to fwctl.

Btw: I'm also preparing some patches to support qemu's acpi table
loader. So, if we like to use qemu's fwcfg, we should use the loader
instead of an own baked solution.


-- 
Kind regards,
Corvin