From nobody Mon Apr 03 14:39:04 2023 X-Original-To: virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PqtnR4YzQz42q59 for ; Mon, 3 Apr 2023 14:39:07 +0000 (UTC) (envelope-from corvink@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PqtnR2kq4z454Q; Mon, 3 Apr 2023 14:39:07 +0000 (UTC) (envelope-from corvink@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1680532747; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sPiTiIKWcmn2F+gznK8HEkW5ZSL3YevvoMw5kWETySw=; b=wlWoUREvWTOgUN0FYnunpNK2WCxgSRfnS2fgxTIDynZo1pQJ0T/VyPOTfQz5fLZ7Dyp2aZ uZtm8sLm2v7gcm+85QDsoRcx6K8UsdKnSRLH+CLqbENKjn4EUgcVq8zeyUbfT/PivaYmjr fRT8/M0c6Szfagqe66EVwCDmZOpVzWeYROLebOEAhSXcRiztrO/pRBUxwjRovbmrtmbm6U JswFMCAPFZVsL3eZEYpiLHatphEmMND2rVi80OynTGbglFF2ud4yFTJoaeDmaLiYloCd7n FRYFggA/d3fWh1mfg1bfIOwo5lmDHxtp5IsQDabfQcre0Fvq1e3JfmutnTC9Xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1680532747; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sPiTiIKWcmn2F+gznK8HEkW5ZSL3YevvoMw5kWETySw=; b=cq3dXNP3aZwE3Gmh+RY4ceLj/FW13XB90Q/rJHhF0hyDWTEhCkFfaGRpMh1yk+BI0wbYwn shrTKH7yMSjpmhk9RLneSF96faN6SSX7U6z8o5JNzMTw2emh0EFcUu3cIPSzUBojs0Q02x GavCaTjh4gwmZt4X/Ko4PnDFra34oULGo8+mWfiaKvVrHoOPXvweKumdyscK3pFx5OffZW ie1zqeDDQTCaFv2K552IyHVzCNzggARgYyAGQjC56TEkDZT7R54cftCRhQGUU0ydp1NWG+ bxYpI6lXvh6nU8ssyPIhltF/u/7Ye4FttnEBg/7HS32lcUQdevhb10V01s9NYQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1680532747; a=rsa-sha256; cv=none; b=ACpsBPTP45N0Usl29JLNGC5GNL3149fF/lsOz4V1v8IZxPmFyg4/HTlhOoYqOKncnU+uTQ 3vkcxiBzYol1Eul5wJxpKWbwxHNJVcMtrppX76A7rS5h3fKWAG0gYPyZJHzzpdz5CDF4dk BRG0+Y9G69ZhMPWN+QGUyYuSqsYI+ddjeQnkHCIanTYCVAgcJCWRxvsc+ihYcKq7pPdUba py42796FRUrI1hCRlCVI5Wb5Cm0V93rggeRUR6dwfmsuz3OllCXQ79+9Akt4fSMR9r/yXI I7+tTPSTAOaR57NCmLevgFE1V38wSGuHVJeccZCKy4xbTRSunhTv71TwOXSbQQ== Received: from [172.21.178.239] (unknown [195.226.174.194]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: corvink) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PqtnQ5LClzVVQ; Mon, 3 Apr 2023 14:39:06 +0000 (UTC) (envelope-from corvink@FreeBSD.org) Message-ID: Subject: Re: [PATCH] OvmfPkg/BhyveBhf: install bhyve's ACPI tables From: Corvin =?ISO-8859-1?Q?K=F6hne?= To: Peter Grehan Cc: virtualization@FreeBSD.org Date: Mon, 03 Apr 2023 16:39:04 +0200 In-Reply-To: References: <20230331123936.540020-1-corvink@FreeBSD.org> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-vq6tboqwTN6TRNrDSfEC" User-Agent: Evolution 3.46.4 List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N --=-vq6tboqwTN6TRNrDSfEC Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2023-04-03 at 21:26 +1000, Peter Grehan wrote: > Hi Corvin, >=20 > > I would like to send the following patch to the EDKII project. > > Therefore, I'd like to get some feedback from the bhyve community > > before > > sending them to EDKII. >=20 > =C2=A0 Thanks for giving a heads-up. >=20 > =C2=A0 The patch looks fine to me. The only minor suggestion I have is to > use=20 > the qemu fwcfg interface to locate the RSDP instead of searching > through=20 > memory, since presumably any new ACPI table functionality in bhyve > would=20 > be after this point in time where qemu fwcfg is already supported. >=20 > later, >=20 > Peter. Hi Peter, thanks for your reply. Using the qemu fwcfg has one big disadvantage: Bhyve's fwctl and qemu's fwcfg can't be used at the same time. Due to backward compatibility reasons, bhyve uses fwctl as default. So, using qemu's fwcfg to locate the rsdp only works, if the user changes his bhyve call. I don't want to use fwctl to locate the rsdp because IMHO we should migrate to fwcfg. So, we shouldn't add new features to fwctl. Btw: I'm also preparing some patches to support qemu's acpi table loader. So, if we like to use qemu's fwcfg, we should use the loader instead of an own baked solution. --=20 Kind regards, Corvin --=-vq6tboqwTN6TRNrDSfEC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgvRSla3m2t/H2U9G2FTaVjFeAmoFAmQq5QgACgkQ2FTaVjFe Amo5+Q//eWW3Bh9hrfSpbtZ1y7fj61sFgQ1MsYxpLvof/73KXwWDvm0xG47fIBrG 5wLzFE5eLPkUHvXWvpz8H0HrHKKo3fBfmL31YHuhoTZz1cE1N6TzH3U4CQrqs7Bd 7LnGah11CGazIFRKkJJEaml3HzjUH2K9YOwQedj4rrmXCN61Ps1m8sAquptcpr1Z m7pdJJl+2ADAuYUkp47sQi/eF65CG1Vae6xhaqB3VjmgPuzsgXQAgwRjUQ6dOtMg 7Lmg+x3yIbl2riKNSzxVlIgfrCas/y4R/NkLYihhebZf0jDFYhd1z3yY2Hdb/znn 4fJluv6vHd2qb8Vw2hBbmQSznD9P5qtNN8UmFLKyPDho+vNMhJJLICgkmdHkaUJT 67tId1ax9ZOMsmkrS4sK3AUD3Y1SFaKS13qZeSrjzuTI5JQHRZRyyvA6IDtbAloH 0bT/el35iEovReyJ5UGE5Yvxcf8kSmKkqcU8RNtTFerXwT0LSgxzLmbQ05aX8TKJ r65JqbA7gNP5OAZ/OaP+pdfU1yaSnrurI94lgOX4KS2WAM4qsRzpu4Y8zjQGa6aA tFeDQSJUCbbBOrphcvCWJIEHz/EHjxDfy0g8vN4IjWejIeDgRiczxU5Vu+fa/uIi AgE+33iEAx+LiMe5GNxOC3nI8B90WEwWHWx7oSETHZf5fhNoF+c= =3BV7 -----END PGP SIGNATURE----- --=-vq6tboqwTN6TRNrDSfEC--