Re: git: 50ecbc5142e1 - main - libipsec: make const-correct

On Tue, 23 Apr 2024, Warner Losh wrote:

> The branch main has been updated by imp:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=50ecbc5142e1c58f2132b351da19c5e4aa5f4e6a
>
> commit 50ecbc5142e1c58f2132b351da19c5e4aa5f4e6a
> Author:     Lexi Winter <lexi@le-Fay.ORG>
> AuthorDate: 2024-04-22 21:56:24 +0000
> Commit:     Warner Losh <imp@FreeBSD.org>
> CommitDate: 2024-04-23 04:36:34 +0000
>
>    libipsec: make const-correct
>
>    - add const to the appropriate places in the libipsec public API and the
>      relevant internal functions needed to support that.
>
>    - replace caddr_t with c_caddr_t in ipsec_dump_policy()
>
>    - update the ipsec_dump_policy manpage to use c_caddr_t (this manpage
>      was already wrong as it had "char *" instead of caddr_t previously).
>
>    While here, update pfkeyv2.h to not cast away const in the PFKEY_*()
>    macros.
>
>    This should not cause any ABI changes as the actual types have not
>    changed.
>
>    Reviewed by: imp
>    Pull Request: https://github.com/freebsd/freebsd-src/pull/1099
> ---
> lib/libipsec/ipsec_dump_policy.c   |  4 ++--
> lib/libipsec/ipsec_get_policylen.c |  2 +-
> lib/libipsec/ipsec_set_policy.3    |  6 +++---
> lib/libipsec/policy_parse.y        | 20 ++++++++++----------
> sys/net/pfkeyv2.h                  |  8 ++++----
> sys/netipsec/ipsec.h               |  6 +++---
> 6 files changed, 23 insertions(+), 23 deletions(-)

I am surprised that this did not break ipsec-tools and/or other ports
for conflicting types for ipsec_set_policy(), ipsec_get_policylen() and
ipsec_dump_policy().

-- 
Bjoern A. Zeeb                                                     r15:7