Re: git: 50ecbc5142e1 - main - libipsec: make const-correct

Bjoern A. Zeeb:
> > commit 50ecbc5142e1c58f2132b351da19c5e4aa5f4e6a
> > Author:     Lexi Winter <lexi@le-Fay.ORG>
> > AuthorDate: 2024-04-22 21:56:24 +0000
> > Commit:     Warner Losh <imp@FreeBSD.org>
> > CommitDate: 2024-04-23 04:36:34 +0000
> > 
> >    libipsec: make const-correct
> 
> I am surprised that this did not break ipsec-tools and/or other ports
> for conflicting types for ipsec_set_policy(), ipsec_get_policylen() and
> ipsec_dump_policy().

it did, actually.  maybe this should be reverted, although the current
situation is also bad since the non-const-correct prototypes cause
issues in client code.

in the specific case of ipsec-tools i feel like a better fix might be to
update ipsec-tools to work with the new prototypes; it does seem to have
support for this (using __ipsec_const), that just isn't enabled on
FreeBSD and i didn't understand the automake logic enough to determine
why.