From nobody Sun Jun 16 20:51:49 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4W2QDZ4g7Dz5PSld; Sun, 16 Jun 2024 20:51:58 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mx1.sbone.de (cross.sbone.de [195.201.62.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE Root Certificate Authority" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4W2QDY0v85z46q1; Sun, 16 Jun 2024 20:51:56 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=softfail (mx1.freebsd.org: 195.201.62.131 is neither permitted nor denied by domain of bzeeb-lists@lists.zabbadoz.net) smtp.mailfrom=bzeeb-lists@lists.zabbadoz.net Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id D0D808D4A126; Sun, 16 Jun 2024 20:51:54 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 0E76E2D029D8; Sun, 16 Jun 2024 20:51:54 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id vhRFsDF_t_IO; Sun, 16 Jun 2024 20:51:50 +0000 (UTC) Received: from strong-iwl0.sbone.de (strong-iwl0.sbone.de [IPv6:fde9:577b:c1a9:4902:b66b:fcff:fef3:e3d2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 080BB2D029D2; Sun, 16 Jun 2024 20:51:49 +0000 (UTC) Date: Sun, 16 Jun 2024 20:51:49 +0000 (UTC) From: "Bjoern A. Zeeb" To: Warner Losh cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 50ecbc5142e1 - main - libipsec: make const-correct In-Reply-To: <202404230452.43N4qhYd063681@gitrepo.freebsd.org> Message-ID: References: <202404230452.43N4qhYd063681@gitrepo.freebsd.org> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.10 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; ASN(0.00)[asn:24940, ipnet:195.201.0.0/16, country:DE]; MIME_TRACE(0.00)[0:+]; MISSING_XM_UA(0.00)[]; TO_DN_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@FreeBSD.org,dev-commits-src-main@FreeBSD.org]; RCVD_COUNT_THREE(0.00)[4]; R_SPF_SOFTFAIL(0.00)[~all]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DMARC_NA(0.00)[zabbadoz.net]; RCVD_TLS_LAST(0.00)[]; RCPT_COUNT_THREE(0.00)[4] X-Rspamd-Queue-Id: 4W2QDY0v85z46q1 On Tue, 23 Apr 2024, Warner Losh wrote: > The branch main has been updated by imp: > > URL: https://cgit.FreeBSD.org/src/commit/?id=50ecbc5142e1c58f2132b351da19c5e4aa5f4e6a > > commit 50ecbc5142e1c58f2132b351da19c5e4aa5f4e6a > Author: Lexi Winter > AuthorDate: 2024-04-22 21:56:24 +0000 > Commit: Warner Losh > CommitDate: 2024-04-23 04:36:34 +0000 > > libipsec: make const-correct > > - add const to the appropriate places in the libipsec public API and the > relevant internal functions needed to support that. > > - replace caddr_t with c_caddr_t in ipsec_dump_policy() > > - update the ipsec_dump_policy manpage to use c_caddr_t (this manpage > was already wrong as it had "char *" instead of caddr_t previously). > > While here, update pfkeyv2.h to not cast away const in the PFKEY_*() > macros. > > This should not cause any ABI changes as the actual types have not > changed. > > Reviewed by: imp > Pull Request: https://github.com/freebsd/freebsd-src/pull/1099 > --- > lib/libipsec/ipsec_dump_policy.c | 4 ++-- > lib/libipsec/ipsec_get_policylen.c | 2 +- > lib/libipsec/ipsec_set_policy.3 | 6 +++--- > lib/libipsec/policy_parse.y | 20 ++++++++++---------- > sys/net/pfkeyv2.h | 8 ++++---- > sys/netipsec/ipsec.h | 6 +++--- > 6 files changed, 23 insertions(+), 23 deletions(-) I am surprised that this did not break ipsec-tools and/or other ports for conflicting types for ipsec_set_policy(), ipsec_get_policylen() and ipsec_dump_policy(). -- Bjoern A. Zeeb r15:7