svn commit: r475335 - head/devel/liteide

[Yuri]

On 7/25/18 11:44 PM, Alexey Dokuchaev wrote:
>> ...
>> +FLAVORS=	qt5 qt4
>> +FLAVOR?=	${FLAVORS:[1]}
> Is this line needed in this case?


Section 7.2 of PHB recommends this line: 
https://www.freebsd.org/doc/en/books/porters-handbook/flavors-using.html


>> ...
>> +.if ${FLAVOR} == qt4
>> +USES+=		qt:4
>> +USE_QT=		corelib gui moc_build network rcc_build uic_build webkit xml
>> +PLIST_SUB+=	QT4="" NO_QT4="@comment "
>> +.else
>> +USES+=		qt:5
>> +USE_QT=		buildtools_build core gui network printsupport widgets xml
>> +PLIST_SUB+=	QT4="@comment " NO_QT4=""
>> +.endif
> Because qt5 is default flavor, and you're checking for qt4 first (qt5 is
> in .else branch) and never for .if ${FLAVOR} == qt5.


Framework checks that flavor is in the list. Here, when flavor isn't 
qt4, it is safe to assume that it is qt5.


Yuri