svn commit: r475335 - head/devel/liteide

[Alexey Dokuchaev]

On Thu, Jul 26, 2018 at 12:02:27AM -0700, Yuri wrote:
> On 7/25/18 11:44 PM, Alexey Dokuchaev wrote:
> >> ...
> >> +FLAVORS=	qt5 qt4
> >> +FLAVOR?=	${FLAVORS:[1]}
> > Is this line needed in this case?
> 
> Section 7.2 of PHB recommends this line:
> https://www.freebsd.org/doc/en/books/porters-handbook/flavors-using.html

Yes, I know, but as long as you never check against the default FLAVOR,
you don't need it.

> > Because qt5 is default flavor, and you're checking for qt4 first (qt5 is
> > in .else branch) and never for .if ${FLAVOR} == qt5.
> 
> Framework checks that flavor is in the list. Here, when flavor isn't
> qt4, it is safe to assume that it is qt5.

Thank you captain.  Not sure why you had to explain this, but that does
not change the point that you don't need FLAVOR?=${FLAVORS:[1]}.  :U
will protect you from undefined variable, and it would be defined in the
Qt4 case because it's not the default flavor.

./danfe