svn commit: r475335 - head/devel/liteide

Alexey Dokuchaev danfe at FreeBSD.org
Thu Jul 26 06:44:09 UTC 2018


On Wed, Jul 25, 2018 at 08:25:54PM +0000, Yuri Victorovich wrote:
> New Revision: 475335
> URL: https://svnweb.freebsd.org/changeset/ports/475335
> 
> Log:
>   devel/liteide: Update 33.3 -> 34
>   
>   Replace QT4/QT5 options with flavors.
>  
> ...
> +FLAVORS=	qt5 qt4
> +FLAVOR?=	${FLAVORS:[1]}

Is this line needed in this case?

> ...
> +.if ${FLAVOR} == qt4
> +USES+=		qt:4
> +USE_QT=		corelib gui moc_build network rcc_build uic_build webkit xml
> +PLIST_SUB+=	QT4="" NO_QT4="@comment "
> +.else
> +USES+=		qt:5
> +USE_QT=		buildtools_build core gui network printsupport widgets xml
> +PLIST_SUB+=	QT4="@comment " NO_QT4=""
> +.endif

Because qt5 is default flavor, and you're checking for qt4 first (qt5 is
in .else branch) and never for .if ${FLAVOR} == qt5.

./danfe


More information about the svn-ports-all mailing list