svn commit: r277876 - in projects/zfsd/head/tests/sys/cddl/zfs/tests: cli_root/zpool_upgrade zil

Will Andrews will at freebsd.org
Thu Jan 29 17:19:02 UTC 2015


On Thu, Jan 29, 2015 at 08:58:57AM -0800, Garrett Cooper wrote:
>     Please use atf_skip instead of atf_fail so the issues don't count
> as failures. If you have bug numbers for the issues that would be nice
> too in the error messages.

To me, skipping tests is only done when the environment is not setup
correctly for the test.

Panics are a special case in that they cause an irreversible abort of the
test run itself, and they *are* failures.

We've adopted a practice of marking such tests as 'expected failure' and
then preemptively failing them.  Does that work for you?

Bugs will come later if I don't have fixes I can commit.

-- 
wca
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-projects/attachments/20150129/85cb7147/attachment.sig>


More information about the svn-src-projects mailing list