svn commit: r277876 - in projects/zfsd/head/tests/sys/cddl/zfs/tests: cli_root/zpool_upgrade zil

Garrett Cooper yaneurabeya at gmail.com
Thu Jan 29 16:59:01 UTC 2015


> On Jan 29, 2015, at 06:23, Will Andrews <will at FreeBSD.org> wrote:
> 
> Author: will
> Date: Thu Jan 29 14:23:31 2015
> New Revision: 277876
> URL: https://svnweb.freebsd.org/changeset/base/277876
> 
> Log:
>  Preemptively fail more tests that cause panics.
> 
> Modified:
>  projects/zfsd/head/tests/sys/cddl/zfs/tests/cli_root/zpool_upgrade/zpool_upgrade_test.sh
>  projects/zfsd/head/tests/sys/cddl/zfs/tests/zil/zil_test.sh
> 
> Modified: projects/zfsd/head/tests/sys/cddl/zfs/tests/cli_root/zpool_upgrade/zpool_upgrade_test.sh
> ==============================================================================
> --- projects/zfsd/head/tests/sys/cddl/zfs/tests/cli_root/zpool_upgrade/zpool_upgrade_test.sh    Thu Jan 29 09:13:34 2015    (r277875)
> +++ projects/zfsd/head/tests/sys/cddl/zfs/tests/cli_root/zpool_upgrade/zpool_upgrade_test.sh    Thu Jan 29 14:23:31 2015    (r277876)
> @@ -219,6 +219,7 @@ zpool_upgrade_007_pos_head()
> }
> zpool_upgrade_007_pos_body()
> {
> +    atf_fail "This test causes a panic on FreeBSD"
>    export TESTCASE_ID=$(echo $(atf_get ident) | cksum -o 2 | cut -f 1 -d " ")
>    . $(atf_get_srcdir)/../../../include/default.cfg
>    . $(atf_get_srcdir)/zpool_upgrade.kshlib
> 
> Modified: projects/zfsd/head/tests/sys/cddl/zfs/tests/zil/zil_test.sh
> ==============================================================================
> --- projects/zfsd/head/tests/sys/cddl/zfs/tests/zil/zil_test.sh    Thu Jan 29 09:13:34 2015    (r277875)
> +++ projects/zfsd/head/tests/sys/cddl/zfs/tests/zil/zil_test.sh    Thu Jan 29 14:23:31 2015    (r277876)
> @@ -33,6 +33,7 @@ zil_001_pos_head()
> }
> zil_001_pos_body()
> {
> +    atf_fail "This test causes a panic on FreeBSD"
>    export TESTCASE_ID=$(echo $(atf_get ident) | cksum -o 2 | cut -f 1 -d " ")
>    . $(atf_get_srcdir)/../../include/default.cfg
>    . $(atf_get_srcdir)/zil.kshlib

Hi Will,
    Please use atf_skip instead of atf_fail so the issues don't count as failures. If you have bug numbers for the issues that would be nice too in the error messages.
Thanks!


More information about the svn-src-projects mailing list