svn commit: r354824 - head/lib/geom/part

Warner Losh imp at bsdimp.com
Tue Nov 19 00:18:14 UTC 2019


On Mon, Nov 18, 2019 at 4:40 PM Rodney W. Grimes <freebsd at gndrsh.dnsmgr.net>
wrote:

> > > In message <20191118204836.GB43295 at raichu>, Mark Johnston writes:
> > > > On Mon, Nov 18, 2019 at 08:35:30PM +0000, Alexey Dokuchaev wrote:
> > > > > On Mon, Nov 18, 2019 at 01:09:19PM -0700, Alan Somers wrote:
> > > > > > On Mon, Nov 18, 2019 at 12:48 PM Mark Johnston <
> markj at freebsd.org> wrote:
> > > > > > > On Mon, Nov 18, 2019 at 12:43:48PM -0700, Alan Somers wrote:
> > > > > > > > On Mon, Nov 18, 2019 at 12:06 PM Mark Johnston <
> markj at freebsd.org>
> > > > > > > wrote:
> > > > > > > >
> > > > > > > > > Author: markj
> > > > > > > > > Date: Mon Nov 18 19:05:52 2019
> > > > > > > > > New Revision: 354824
> > > > > > > > > URL: https://svnweb.freebsd.org/changeset/base/354824
> > > > > > > > >
> > > > > > > > > Log:
> > > > > > > > >   Fix grammar in gpart.8.
> > > > > > > > >
> > > > > > > > >   PR:           241973
> > > > > > > > >   MFC after:    3 days
> > > > > > > > >
> > > > > > > > > Modified:
> > > > > > > > >   head/lib/geom/part/gpart.8
> > > > > > > >
> > > > > > > > Don't forget to bump the .Dd date.
> > > > > > >
> > > > > > > AFAIK we do not bump .Dd for such changes, only for content
> changes.
> > > > > >
> > > > > > Isn't that a content change?  I thought anything displayed to
> the user
> > > > > > counts as a content change?
> > > > >
> > > > > I presume that "content" means more like semantic, functional
> changes
> > > > > that affect some particular meaning.  Grammar fixes are just, well,
> > > > > grammar fixes and thus do not warrant .Dd bump.
> > > >
> > > > Indeed, this was always my understanding as well.  I can't find a
> > > > concrete definition anywhere.  I don't understand why it would be
> useful
> > > > as a user to see the date of the last "content change" if such
> changes
> > > > might consist only of a small formatting change or typo fix.
> > > >
> > >
> > > Should this be documented in the committers guide?
> >
> > This should be documented someplace,
> > that place probably being where bumping of .Dd is documented as a
> minimum.
> that place also being where .Dd is documented.
>

The issue, though, is that we get the mdoc man page from upstream
somewhere, so we'd have to change that. Plus, upstream seems to have a
different .Dd policy that we do ($Mdocdate$ is the last modification time,
for example, in OpenBSD's CVS client). So it's a bit tricky to implement.

Warner


More information about the svn-src-head mailing list