svn commit: r354824 - head/lib/geom/part

Rodney W. Grimes freebsd at gndrsh.dnsmgr.net
Mon Nov 18 23:40:07 UTC 2019


> > In message <20191118204836.GB43295 at raichu>, Mark Johnston writes:
> > > On Mon, Nov 18, 2019 at 08:35:30PM +0000, Alexey Dokuchaev wrote:
> > > > On Mon, Nov 18, 2019 at 01:09:19PM -0700, Alan Somers wrote:
> > > > > On Mon, Nov 18, 2019 at 12:48 PM Mark Johnston <markj at freebsd.org> wrote:
> > > > > > On Mon, Nov 18, 2019 at 12:43:48PM -0700, Alan Somers wrote:
> > > > > > > On Mon, Nov 18, 2019 at 12:06 PM Mark Johnston <markj at freebsd.org>
> > > > > > wrote:
> > > > > > >
> > > > > > > > Author: markj
> > > > > > > > Date: Mon Nov 18 19:05:52 2019
> > > > > > > > New Revision: 354824
> > > > > > > > URL: https://svnweb.freebsd.org/changeset/base/354824
> > > > > > > >
> > > > > > > > Log:
> > > > > > > >   Fix grammar in gpart.8.
> > > > > > > >
> > > > > > > >   PR:           241973
> > > > > > > >   MFC after:    3 days
> > > > > > > >
> > > > > > > > Modified:
> > > > > > > >   head/lib/geom/part/gpart.8
> > > > > > >
> > > > > > > Don't forget to bump the .Dd date.
> > > > > >
> > > > > > AFAIK we do not bump .Dd for such changes, only for content changes.
> > > > > 
> > > > > Isn't that a content change?  I thought anything displayed to the user
> > > > > counts as a content change?
> > > > 
> > > > I presume that "content" means more like semantic, functional changes
> > > > that affect some particular meaning.  Grammar fixes are just, well,
> > > > grammar fixes and thus do not warrant .Dd bump.
> > >
> > > Indeed, this was always my understanding as well.  I can't find a
> > > concrete definition anywhere.  I don't understand why it would be useful
> > > as a user to see the date of the last "content change" if such changes
> > > might consist only of a small formatting change or typo fix.
> > >
> > 
> > Should this be documented in the committers guide?
> 
> This should be documented someplace,
> that place probably being where bumping of .Dd is documented as a minimum.
that place also being where .Dd is documented.

> > Cy Schubert <Cy.Schubert at cschubert.com>
> -- 
> Rod Grimes                                                 rgrimes at freebsd.org
-- 
Rod Grimes                                                 rgrimes at freebsd.org


More information about the svn-src-head mailing list