svn commit: r343391 - head/tools/tools/tinybsd

Oleksandr Tymoshenko gonzo at freebsd.org
Thu Jan 24 20:08:48 UTC 2019


Rodney W. Grimes (freebsd at pdx.rh.CN85.dnsmgr.net) wrote:
> > Author: gonzo
> > Date: Thu Jan 24 06:34:29 2019
> > New Revision: 343391
> > URL: https://svnweb.freebsd.org/changeset/base/343391
> > 
> > Log:
> >   Fix prompt for MFSROOT in tinybsd
> >   
> >   tinybsd offers two choices when prompting user for MFSROOT: 'YES'
> >   and 'NO'. Script logic only handles 'yes'. Change offered values
> >   to lower case.
> 
> Why not fix this so that [Yy][Ee][Ss] is accepted?

I thought about it but actual end-to-end verification of such fix would
require going through whole build (and learning how tinybsd script
works). It's a bit more effort than I would like to spend on the tool I
don't work with and with the number of users I don't know of. The
committed patch was readily available, easily verifiable and a step
forward, a tiny one but nevertheless.

If anybody wants to implement proper fix - feel free to reopen PR and
take over it.

-- 
gonzo


More information about the svn-src-head mailing list