svn commit: r343392 - head/sys/netinet6

Hans Petter Selasky hselasky at FreeBSD.org
Thu Jan 24 08:15:42 UTC 2019


Author: hselasky
Date: Thu Jan 24 08:15:41 2019
New Revision: 343392
URL: https://svnweb.freebsd.org/changeset/base/343392

Log:
  Fix duplicate acquiring of refcount when joining IPv6 multicast groups.
  This was observed by starting and stopping rpcbind(8) multiple times.
  
  PR:			233535
  Differential Revision:	https://reviews.freebsd.org/D18887
  Reviewed by:		bz (net)
  Tested by:		ae
  MFC after:		1 week
  Sponsored by:		Mellanox Technologies

Modified:
  head/sys/netinet6/in6_mcast.c

Modified: head/sys/netinet6/in6_mcast.c
==============================================================================
--- head/sys/netinet6/in6_mcast.c	Thu Jan 24 06:34:29 2019	(r343391)
+++ head/sys/netinet6/in6_mcast.c	Thu Jan 24 08:15:41 2019	(r343392)
@@ -2178,7 +2178,10 @@ in6p_join_group(struct inpcb *inp, struct sockopt *sop
 			IN6_MULTI_UNLOCK();
 			goto out_im6o_free;
 		}
-		in6m_acquire(inm);
+		/*
+		 * NOTE: Refcount from in6_joingroup_locked()
+		 * is protecting membership.
+		 */
 		imo->im6o_membership[idx] = inm;
 	} else {
 		CTR1(KTR_MLD, "%s: merge inm state", __func__);


More information about the svn-src-head mailing list