svn commit: r340326 - head

[Conrad Meyer]

I absolutely approve of Ben's excellent addition to UPDATING, a text document.

Your demands for additional scrutiny and time-wasting around code
review are ridiculous and disproportionate, and certainly a poor
reward for Ben's straightforward and unimpeachable effort to improve
our UPDATING documentation.

Ben, thank you for submitting and committing the UPDATING change and
please try to ignore Rod's hyper-criticism.

Conrad


On Sat, Nov 10, 2018 at 5:07 PM Rodney W. Grimes
<freebsd at pdx.rh.cn85.dnsmgr.net> wrote:
>
> [ Charset UTF-8 unsupported, converting... ]
> > On Sun, 11 Nov 2018 at 2:43 am, Rodney W. Grimes <
> > freebsd at pdx.rh.cn85.dnsmgr.net> wrote:
> >
> > > If your going to bother with a differential, and invite people to
> > > it you should give them at least 24 hours, and preferably 72 hours
> > > to respond to the new review.  Reviews that last < 4 hours are not
> > > code reviews.
> > >
> > > --
> > > Rod Grimes
> > > rgrimes at freebsd.org
> > >
> > Hi Rod,
> >
> > Sorry. The main reason I submitted the code review is because I do not have
> > my src commit bit, so needed to seek approval to commit.
>
> All the more reason for it to wait until the people you *invited* to
> the review to have a chance to respond.
>
> I do not believe an "accept" in a review is an "approve to commit
> beyond your normal scope".
>
> Was cem aware that he was "approving a non src committer to commit
> this change to the src tree" as your review has no mention that you
> are seeking src bit approval to commit there.
>
> >
> > I felt the need to commit the UPDATING entry was time sensitive, given the
> > change it was notifying users of had already been committed.
> >
> > Regards,
> > Ben
> > --
>
> --
> Rod Grimes                                                 rgrimes at freebsd.org
>