svn commit: r340326 - head

[Warner Losh]

On Sat, Nov 10, 2018, 6:38 PM Mark Johnston <markj at freebsd.org wrote:

> On Sat, Nov 10, 2018 at 05:07:38PM -0800, Rodney W. Grimes wrote:
> > [ Charset UTF-8 unsupported, converting... ]
> > > On Sun, 11 Nov 2018 at 2:43 am, Rodney W. Grimes <
> > > freebsd at pdx.rh.cn85.dnsmgr.net> wrote:
> > >
> > > > If your going to bother with a differential, and invite people to
> > > > it you should give them at least 24 hours, and preferably 72 hours
> > > > to respond to the new review.  Reviews that last < 4 hours are not
> > > > code reviews.
> > > >
> > > > --
> > > > Rod Grimes
> > > > rgrimes at freebsd.org
> > > >
> > > Hi Rod,
> > >
> > > Sorry. The main reason I submitted the code review is because I do not
> have
> > > my src commit bit, so needed to seek approval to commit.
> >
> > All the more reason for it to wait until the people you *invited* to
> > the review to have a chance to respond.
> >
> > I do not believe an "accept" in a review is an "approve to commit
> > beyond your normal scope".
>
> I think that's being pedantic.  UPDATING is an English text file, no
> special qualification is needed to add an entry.  Ben waited for two
> months before committing r340318; I'm sure he appreciates the need to
> give reviewers time to review anything controversial.
>
> > Was cem aware that he was "approving a non src committer to commit
> > this change to the src tree" as your review has no mention that you
> > are seeking src bit approval to commit there.
>
> I doubt he worried too much about the distinction.  If a committer
> clicks "accept," it means, "the change looks good to me."  Does it
> matter how it gets committed, at least in this trivial case?
>
> > > I felt the need to commit the UPDATING entry was time sensitive, given
> the
> > > change it was notifying users of had already been committed.
>
> That makes perfect sense to me.
>


As the nominal owner of UPDATING, this is exactly what I invented for: to
update users of time critical information.  If there are improvements to
the language,  they can be made. Churn causes very little trouble for this
file.

Warner

>