svn commit: r335908 - head/sys/conf

[Cy Schubert]

In message <bf1f68d2-a45e-c356-c6b9-cd1c6449cd8e at FreeBSD.org>, Bryan 
Drewery wr
ites:
> This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
> --5LBlvAHx6wd2MBY6ZJGLCKfNccUC2f3P7
> Content-Type: multipart/mixed; boundary="FxkUanNxVoyIpem522qWwd6g1GQCAsxqA";
>  protected-headers="v1"
> From: Bryan Drewery <bdrewery at FreeBSD.org>
> To: Cy Schubert <Cy.Schubert at cschubert.com>
> Cc: src-committers at freebsd.org, svn-src-all at freebsd.org,
>  svn-src-head at freebsd.org
> Message-ID: <bf1f68d2-a45e-c356-c6b9-cd1c6449cd8e at FreeBSD.org>
> Subject: Re: svn commit: r335908 - head/sys/conf
> References: <201807032006.w63K6c3E069211 at slippy.cwsent.com>
> In-Reply-To: <201807032006.w63K6c3E069211 at slippy.cwsent.com>
>
> --FxkUanNxVoyIpem522qWwd6g1GQCAsxqA
> Content-Type: text/plain; charset=utf-8
> Content-Language: en-US
> Content-Transfer-Encoding: quoted-printable
>
> On 7/3/2018 1:06 PM, Cy Schubert wrote:
> > In message <201807032003.w63K3JD3071764 at repo.freebsd.org>, Bryan=20
> > Drewery writes
> > :
> >> Author: bdrewery
> >> Date: Tue Jul  3 20:03:19 2018
> >> New Revision: 335908
> >> URL: https://svnweb.freebsd.org/changeset/base/335908
> >>
> >> Log:
> >>   Fix r335906+r335907 to not pass multiple source files to genoffset_t=
> est.o t
> >> arget.
> >>  =20
> >>   This is working around a bug with the FAST_DEPEND logic with custom =
> targets
> >>   that use .ALLSRC.
> >>  =20
> >>   Reported by:	mmacy
> >>
> >> Modified:
> >>   head/sys/conf/kern.post.mk
> >>
> >> Modified: head/sys/conf/kern.post.mk
> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D
> >> =3D
> >> --- head/sys/conf/kern.post.mk	Tue Jul  3 19:24:52 2018	(r33590
> >> 7)
> >> +++ head/sys/conf/kern.post.mk	Tue Jul  3 20:03:19 2018	(r33590
> >> 8)
> >> @@ -195,8 +195,8 @@ genoffset.o: $S/kern/genoffset.c
> >>  # is to exercise the CTASSERT that checks that the offsets in the off=
> set.inc
> >>  # _lite struct(s) match those in the original(s).=20
> >>  genoffset_test.o: $S/kern/genoffset.c offset.inc
> >> -	${CC} -c ${CFLAGS:N-flto:N-fno-common} -DOFFSET_TEST ${.ALLSRC:M*.c}=
>  \
> >> -	    -o ${.TARGET}
> >> +	${CC} -c ${CFLAGS:N-flto:N-fno-common} -DOFFSET_TEST \
> >> +	    $S/kern/genoffset.c -o ${.TARGET}
> >=20
> > This still won't build because of -c and -o.
>
> -c is just a hint to the compiler to not run the linker. It's fine. We
> even have this pattern used in share/mk/bsd.suffixes.mk.

I sent my second reply to you before you sent your first one to me. 
We're good now.

Sorry for the spam.


-- 
Cheers,
Cy Schubert <Cy.Schubert at cschubert.com>
FreeBSD UNIX:  <cy at FreeBSD.org>   Web:  http://www.FreeBSD.org

	The need of the many outweighs the greed of the few.