svn commit: r335908 - head/sys/conf

[Bryan Drewery]

On 7/3/2018 1:06 PM, Cy Schubert wrote:
> In message <201807032003.w63K3JD3071764 at repo.freebsd.org>, Bryan 
> Drewery writes
> :
>> Author: bdrewery
>> Date: Tue Jul  3 20:03:19 2018
>> New Revision: 335908
>> URL: https://svnweb.freebsd.org/changeset/base/335908
>>
>> Log:
>>   Fix r335906+r335907 to not pass multiple source files to genoffset_test.o t
>> arget.
>>   
>>   This is working around a bug with the FAST_DEPEND logic with custom targets
>>   that use .ALLSRC.
>>   
>>   Reported by:	mmacy
>>
>> Modified:
>>   head/sys/conf/kern.post.mk
>>
>> Modified: head/sys/conf/kern.post.mk
>> =============================================================================
>> =
>> --- head/sys/conf/kern.post.mk	Tue Jul  3 19:24:52 2018	(r33590
>> 7)
>> +++ head/sys/conf/kern.post.mk	Tue Jul  3 20:03:19 2018	(r33590
>> 8)
>> @@ -195,8 +195,8 @@ genoffset.o: $S/kern/genoffset.c
>>  # is to exercise the CTASSERT that checks that the offsets in the offset.inc
>>  # _lite struct(s) match those in the original(s). 
>>  genoffset_test.o: $S/kern/genoffset.c offset.inc
>> -	${CC} -c ${CFLAGS:N-flto:N-fno-common} -DOFFSET_TEST ${.ALLSRC:M*.c} \
>> -	    -o ${.TARGET}
>> +	${CC} -c ${CFLAGS:N-flto:N-fno-common} -DOFFSET_TEST \
>> +	    $S/kern/genoffset.c -o ${.TARGET}
> 
> This still won't build because of -c and -o.

-c is just a hint to the compiler to not run the linker. It's fine. We
even have this pattern used in share/mk/bsd.suffixes.mk.

> 
>>  
>>  assym.inc: $S/kern/genassym.sh genassym.o genoffset_test.o
>>  	NM='${NM}' NMFLAGS='${NMFLAGS}' sh $S/kern/genassym.sh genassym.o > ${.
>> TARGET}
>>
> 
> 


-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20180703/ce9543b7/attachment.sig>