svn commit: r325721 - in head/sys: kern sys

[Mateusz Guzik]

On Sun, Nov 12, 2017 at 5:32 AM, Mark Johnston <markj at freebsd.org> wrote:

> On Sat, Nov 11, 2017 at 06:04:40PM +0000, Mateusz Guzik wrote:
> > Author: mjg
> > Date: Sat Nov 11 18:04:39 2017
> > New Revision: 325721
> > URL: https://svnweb.freebsd.org/changeset/base/325721
> >
> > Log:
> >   Add pfind_any
> >
> >   It looks for both regular and zombie processes. This avoids allproc
> relocking
> >   previously seen with pfind -> zpfind calls.
> >
> > +/*
> > + * Same as pfind but allow zombies.
> > + */
> > +struct proc *
> > +pfind_any(pid_t pid)
> > +{
> > +     struct proc *p;
> > +
> > +     sx_slock(&allproc_lock);
> > +     p = pfind_locked(pid);
> > +     if (p == NULL)
> > +             p = zpfind_locked(pid);
> > +     sx_sunlock(&allproc_lock);
> > +
> > +     return (p);
> > +}
>
> Can't this be written as pget(pid, 0, &p)?
>

It can, but at the expense of avoidable branch-fest. pget is rarely called
in comparison
anyway.

-- 
Mateusz Guzik <mjguzik gmail.com>