svn commit: r325721 - in head/sys: kern sys

[Mark Johnston]

On Sat, Nov 11, 2017 at 06:04:40PM +0000, Mateusz Guzik wrote:
> Author: mjg
> Date: Sat Nov 11 18:04:39 2017
> New Revision: 325721
> URL: https://svnweb.freebsd.org/changeset/base/325721
> 
> Log:
>   Add pfind_any
>   
>   It looks for both regular and zombie processes. This avoids allproc relocking
>   previously seen with pfind -> zpfind calls.
> 
> Modified:
>   head/sys/kern/kern_event.c
>   head/sys/kern/kern_proc.c
>   head/sys/kern/kern_sig.c
>   head/sys/sys/proc.h
> 
> Modified: head/sys/kern/kern_proc.c
> ==============================================================================
> --- head/sys/kern/kern_proc.c	Sat Nov 11 18:03:26 2017	(r325720)
> +++ head/sys/kern/kern_proc.c	Sat Nov 11 18:04:39 2017	(r325721)
> @@ -353,6 +353,23 @@ pfind(pid_t pid)
>  	return (p);
>  }
>  
> +/*
> + * Same as pfind but allow zombies.
> + */
> +struct proc *
> +pfind_any(pid_t pid)
> +{
> +	struct proc *p;
> +
> +	sx_slock(&allproc_lock);
> +	p = pfind_locked(pid);
> +	if (p == NULL)
> +		p = zpfind_locked(pid);
> +	sx_sunlock(&allproc_lock);
> +
> +	return (p);
> +}

Can't this be written as pget(pid, 0, &p)?