svn commit: r311225 - head/sys/netinet

[Mark Johnston]

On Sat, Jan 07, 2017 at 02:31:28PM -0500, George Neville-Neil wrote:
> 
> 
> On 7 Jan 2017, at 14:23, George Neville-Neil wrote:
> 
> > On 4 Jan 2017, at 13:26, Mark Johnston wrote:
> >
> >> On Wed, Jan 04, 2017 at 02:19:13AM +0000, George V. Neville-Neil 
> >> wrote:
> >>> Author: gnn
> >>> Date: Wed Jan  4 02:19:13 2017
> >>> New Revision: 311225
> >>> URL: https://svnweb.freebsd.org/changeset/base/311225
> >>>
> >>> Log:
> >>>   Fix DTrace TCP tracepoints to not use mtod() as it is both 
> >>> unnecessary and
> >>>   dangerous.  Those wanting data from an mbuf should use DTrace 
> >>> itself to get
> >>>   the data.
> >>
> >> I think you also need to update the types in in_kdtrace.c, and add a
> >> translator for struct mbuf * to ipinfo_t.
> >
> > Fair points.
> >
> 
> Actually, following up to myself, this does not need to be done just 
> yet.  The pkt_info stuff is currently always NULL.  I'm working on a 
> copyoutmbuf() subroutine that will make all of this much cleaner.

The pkt_info stuff is unrelated to this - ipinfo_t is the third
argument to the tcp probes. The translator which expects a pointer to
the IP header is now getting a pointer to an mbuf, so this change
effectively breaks scripts that use args[2] in a tcp:::send or
tcp:::receive probe (among others).