svn commit: r311225 - head/sys/netinet
George Neville-Neil
gnn at freebsd.org
Sat Jan 7 19:31:33 UTC 2017
On 7 Jan 2017, at 14:23, George Neville-Neil wrote:
> On 4 Jan 2017, at 13:26, Mark Johnston wrote:
>
>> On Wed, Jan 04, 2017 at 02:19:13AM +0000, George V. Neville-Neil
>> wrote:
>>> Author: gnn
>>> Date: Wed Jan 4 02:19:13 2017
>>> New Revision: 311225
>>> URL: https://svnweb.freebsd.org/changeset/base/311225
>>>
>>> Log:
>>> Fix DTrace TCP tracepoints to not use mtod() as it is both
>>> unnecessary and
>>> dangerous. Those wanting data from an mbuf should use DTrace
>>> itself to get
>>> the data.
>>
>> I think you also need to update the types in in_kdtrace.c, and add a
>> translator for struct mbuf * to ipinfo_t.
>
> Fair points.
>
Actually, following up to myself, this does not need to be done just
yet. The pkt_info stuff is currently always NULL. I'm working on a
copyoutmbuf() subroutine that will make all of this much cleaner.
Best,
George
More information about the svn-src-head
mailing list