svn commit: r314142 - head/sys/dev/ce

Pedro F. Giffuni pfg at FreeBSD.org
Thu Feb 23 15:30:23 UTC 2017


Author: pfg
Date: Thu Feb 23 15:30:21 2017
New Revision: 314142
URL: https://svnweb.freebsd.org/changeset/base/314142

Log:
  dev/ce: double assignment.
  
  The code is not operational right now so just comment away an obviously
  useless assignment. Fix some typos while here.
  
  Found with: coccinelle (da.cocci)

Modified:
  head/sys/dev/ce/ceddk.c

Modified: head/sys/dev/ce/ceddk.c
==============================================================================
--- head/sys/dev/ce/ceddk.c	Thu Feb 23 15:10:46 2017	(r314141)
+++ head/sys/dev/ce/ceddk.c	Thu Feb 23 15:30:21 2017	(r314142)
@@ -621,10 +621,10 @@ void ce_stop_chan (ce_chan_t *c)
 	TAU32_UserRequest *req;
 	CE_DEQUEUE (b->cr.queue, req);
 
-	/* XXXRIK: This function should be for comleteness, but for now I
-	 * don't use it. So I just start to write and didn't finished it yet.
-	 * It and it is VERY BUGGY!!! Do not use it. If you really
-	 * need it ask me to fix it or rewrite it by your self.
+	/* XXXRIK: This function should be for completeness, but for now I
+	 * don't use it. I just started to write and haven't finished it yet.
+	 * It is VERY BUGGY!!! Do not use it. If you really need
+	 * it ask me to fix it or rewrite it by yourself.
 	 * Note: most buggy part of it in ce_on_config_stop!
 	 */
 	if (!req) {
@@ -632,8 +632,8 @@ void ce_stop_chan (ce_chan_t *c)
 			      "UserRequest (%s:%d)\n", __FUNCTION__, __LINE__));
 		return;
 	}
-	req->Command = TAU32_Configure_Commit |
-		       TAU32_Tx_Stop | TAU32_Rx_Stop;
+//	req->Command = TAU32_Configure_Commit |
+//		       TAU32_Tx_Stop | TAU32_Rx_Stop;
 	req->Command = 0;
 	req->Io.ChannelNumber = c->num;
 	req->pCallback = ce_on_config_stop;


More information about the svn-src-head mailing list