svn commit: r314141 - head/usr.sbin/rtadvd

Pedro F. Giffuni pfg at FreeBSD.org
Thu Feb 23 15:10:48 UTC 2017


Author: pfg
Date: Thu Feb 23 15:10:46 2017
New Revision: 314141
URL: https://svnweb.freebsd.org/changeset/base/314141

Log:
  rtadvd(8): double assignment.
  
  Remove doubtful initialization since the value will be overwritten
  immediately afterwards.
  
  Found with: coccinelle (da.cocci)

Modified:
  head/usr.sbin/rtadvd/config.c

Modified: head/usr.sbin/rtadvd/config.c
==============================================================================
--- head/usr.sbin/rtadvd/config.c	Thu Feb 23 15:05:01 2017	(r314140)
+++ head/usr.sbin/rtadvd/config.c	Thu Feb 23 15:10:46 2017	(r314141)
@@ -1395,7 +1395,6 @@ make_packet(struct rainfo *rai)
 	ra->nd_ra_code = 0;
 	ra->nd_ra_cksum = 0;
 	ra->nd_ra_curhoplimit = (uint8_t)(0xff & rai->rai_hoplimit);
-	ra->nd_ra_flags_reserved = 0; /* just in case */
 	/*
 	 * XXX: the router preference field, which is a 2-bit field, should be
 	 * initialized before other fields.


More information about the svn-src-head mailing list