svn commit: r299926 - head/lib/libpam/modules/pam_unix

[Ed Maste]

On 16 May 2016 at 04:34, Don Lewis <truckman at freebsd.org> wrote:
> Author: truckman
> Date: Mon May 16 08:34:17 2016
> New Revision: 299926
> URL: https://svnweb.freebsd.org/changeset/base/299926
>
> Log:
>   Hoist the getpwnam() call outside the first if/else block in
>   pam_sm_chauthtok().  Set user = getlogin() inside the true
>   branch so that it is initialized for the following PAM_LOG()
>   call.  This is how it is done in pam_sm_authenticate().

Unfortunately this triggers a warning on powerpc/powerpc64:

/scratch/tmp/emaste/freebsd/lib/libpam/modules/pam_unix/pam_unix.c: In
function 'pam_sm_chauthtok':
/scratch/tmp/emaste/freebsd/lib/libpam/modules/pam_unix/pam_unix.c:278:
warning: 'retval' may be used uninitialized in this function

I don't see why GCC warns now and did not before, though.