svn commit: r299926 - head/lib/libpam/modules/pam_unix

[Don Lewis]

Author: truckman
Date: Mon May 16 08:34:17 2016
New Revision: 299926
URL: https://svnweb.freebsd.org/changeset/base/299926

Log:
  Hoist the getpwnam() call outside the first if/else block in
  pam_sm_chauthtok().  Set user = getlogin() inside the true
  branch so that it is initialized for the following PAM_LOG()
  call.  This is how it is done in pam_sm_authenticate().
  
  Reported by:	Coverity
  CID:		272498
  MFC after:	1 week

Modified:
  head/lib/libpam/modules/pam_unix/pam_unix.c

Modified: head/lib/libpam/modules/pam_unix/pam_unix.c
==============================================================================
--- head/lib/libpam/modules/pam_unix/pam_unix.c	Mon May 16 08:32:21 2016	(r299925)
+++ head/lib/libpam/modules/pam_unix/pam_unix.c	Mon May 16 08:34:17 2016	(r299926)
@@ -278,13 +278,13 @@ pam_sm_chauthtok(pam_handle_t *pamh, int
 	int pfd, tfd, retval;
 
 	if (openpam_get_option(pamh, PAM_OPT_AUTH_AS_SELF))
-		pwd = getpwnam(getlogin());
+		user = getlogin();
 	else {
 		retval = pam_get_user(pamh, &user, NULL);
 		if (retval != PAM_SUCCESS)
 			return (retval);
-		pwd = getpwnam(user);
 	}
+	pwd = getpwnam(user);
 
 	if (pwd == NULL)
 		return (PAM_AUTHTOK_RECOVERY_ERR);