svn commit: r298377 - head/sys/dev/acpica

[Jung-uk Kim]

On 04/20/16 06:27 PM, John Baldwin wrote:
> On Wednesday, April 20, 2016 09:21:47 PM Jung-uk Kim wrote:
>> Author: jkim
>> Date: Wed Apr 20 21:21:47 2016
>> New Revision: 298377
>> URL: https://svnweb.freebsd.org/changeset/base/298377
>>
>> Log:
>>   Remove query flag from acpi_EvaluateOSC().  This function does not support
>>   return buffer (yet).
> 
> Hmm, I should probably fix that then instead?  The PCI variant is (now)
> incorrectly assuming it gets the buffer back in the array it passed in.
> The 5.0 spec at least says that the returned values are identical in
> length to the array passed in.  We could either add a new parameter for
> the outputs or copy them to the inputs.  Perhaps the former is better?

Yes and yes.

> I'd still prefer to set caps[0] in the common code since it is not
> UUID-specific but something all _OSC callers have to do.

Agreed iff we implement the return buffer.

Jung-uk Kim

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20160420/2e221933/attachment.sig>